chore(asm): use byte pointer instead of c_char_p #10438

christophe-papazian · 2024-08-29T08:14:16Z

Backport of 10428

Checklist

PR author has checked that all the criteria below are met
The PR description includes an overview of the change
The PR description articulates the motivation for the change
The change includes tests OR the PR description describes a testing strategy
The PR description notes risks associated with the change, if any
Newly-added code is easy to change
The change follows the library release note guidelines
The change includes or references documentation updates if necessary
Backport labels are set (if applicable)

Reviewer Checklist

Reviewer has checked that all the criteria below are met
Title is accurate
All changes are related to the pull request's stated goal
Avoids breaking API changes
Testing strategy adequately addresses listed risks
Newly-added code is easy to change
Release note makes sense to a user of the library
If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
Backport labels are set in a manner that is consistent with the release branch maintenance policy

To improve waf bindings efficiency, use byte pointer instead of c_char_p for string retrieval from libddwaf ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 46bb2a8)

datadog-dd-trace-py-rkomorn · 2024-08-29T08:28:30Z

Datadog Report

Branch report: backport-10428-to-2.12
Commit report: c1f7e80
Test service: dd-trace-py

✅ 0 Failed, 111119 Passed, 2808 Skipped, 53m 49.05s Total Time

codecov-commenter · 2024-08-29T08:40:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (2.12@71fd926). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             2.12   #10438   +/-   ##
=======================================
  Coverage        ?    9.85%           
=======================================
  Files           ?     1409           
  Lines           ?   120789           
  Branches        ?        0           
=======================================
  Hits            ?    11909           
  Misses          ?   108880           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pr-commenter · 2024-08-29T09:01:02Z

Benchmarks

Benchmark execution time: 2024-08-29 09:01:00

Comparing candidate commit c1f7e80 in PR branch backport-10428-to-2.12 with baseline commit 71fd926 in branch 2.12.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

This is a minor improvement for the libddwaf interface, applying the same idea in #10438 to parameter strings. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

This is a minor improvement for the libddwaf interface, applying the same idea in #10438 to parameter strings. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 97fa6d6)

…2.11] (#10603) Backport 97fa6d6 from #10596 to 2.11. This is a minor improvement for the libddwaf interface, applying the same idea in #10438 to parameter strings. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Christophe Papazian <[email protected]> Co-authored-by: Alberto Vara <[email protected]>

…2.12] (#10604) Backport 97fa6d6 from #10596 to 2.12. This is a minor improvement for the libddwaf interface, applying the same idea in #10438 to parameter strings. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Christophe Papazian <[email protected]> Co-authored-by: Alberto Vara <[email protected]>

This is a minor improvement for the libddwaf interface, applying the same idea in #10438 to parameter strings. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 97fa6d6)

…2.13] (#10626) Backport 97fa6d6 from #10596 to 2.13. This is a minor improvement for the libddwaf interface, applying the same idea in #10438 to parameter strings. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Christophe Papazian <[email protected]>

christophe-papazian added enhancement changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Aug 29, 2024

christophe-papazian changed the title ~~fix(internal): handle native module specs [backport 2.12] (#10428)~~ chore(asm): use byte pointer instead of c_char_p [backport 2.12] (#10428) Aug 29, 2024

christophe-papazian changed the title ~~chore(asm): use byte pointer instead of c_char_p [backport 2.12] (#10428)~~ chore(asm): use byte pointer instead of c_char_p Aug 29, 2024

christophe-papazian added changelog/no-changelog A changelog entry is not required for this PR. backport 2.11 and removed changelog/no-changelog A changelog entry is not required for this PR. labels Aug 29, 2024

christophe-papazian marked this pull request as ready for review August 29, 2024 08:19

christophe-papazian requested a review from a team as a code owner August 29, 2024 08:19

christophe-papazian enabled auto-merge (squash) August 29, 2024 08:19

avara1986 approved these changes Aug 29, 2024

View reviewed changes

christophe-papazian removed the backport 2.11 label Aug 29, 2024

christophe-papazian merged commit 8d3373c into 2.12 Aug 29, 2024
135 of 144 checks passed

christophe-papazian deleted the backport-10428-to-2.12 branch August 29, 2024 09:45

christophe-papazian mentioned this pull request Sep 10, 2024

chore(asm): use parameternamelength for libddwaf interface #10596

Merged

2 tasks

github-actions bot mentioned this pull request Sep 10, 2024

chore(asm): use parameternamelength for libddwaf interface [backport 2.11] #10603

Merged

2 tasks

github-actions bot mentioned this pull request Sep 10, 2024

chore(asm): use parameternamelength for libddwaf interface [backport 2.12] #10604

Merged

2 tasks

github-actions bot mentioned this pull request Sep 11, 2024

chore(asm): use parameternamelength for libddwaf interface [backport 2.13] #10626

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(asm): use byte pointer instead of c_char_p #10438

chore(asm): use byte pointer instead of c_char_p #10438

christophe-papazian commented Aug 29, 2024 •

edited

Loading

datadog-dd-trace-py-rkomorn bot commented Aug 29, 2024 •

edited

Loading

codecov-commenter commented Aug 29, 2024

pr-commenter bot commented Aug 29, 2024

chore(asm): use byte pointer instead of c_char_p #10438

chore(asm): use byte pointer instead of c_char_p #10438

Conversation

christophe-papazian commented Aug 29, 2024 • edited Loading

Checklist

Reviewer Checklist

datadog-dd-trace-py-rkomorn bot commented Aug 29, 2024 • edited Loading

Datadog Report

codecov-commenter commented Aug 29, 2024

Codecov Report

pr-commenter bot commented Aug 29, 2024

Benchmarks

christophe-papazian commented Aug 29, 2024 •

edited

Loading

datadog-dd-trace-py-rkomorn bot commented Aug 29, 2024 •

edited

Loading