-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test_visibility): rename and privatize CI Visibility API to Test Visibility #10425
chore(test_visibility): rename and privatize CI Visibility API to Test Visibility #10425
Conversation
|
BenchmarksBenchmark execution time: 2024-09-06 17:25:38 Comparing candidate commit 5b5db1d in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics. |
Datadog ReportBranch report: ✅ 0 Failed, 138694 Passed, 1638 Skipped, 4h 14m 23.7s Total Time New Flaky Tests (1)
|
…p' into romain.komorn/SDTEST-169/ci_visibilty_manual_api_cleanup_make_internal_api
…ilty_manual_api_cleanup
@mabdinur , @ZStriker19 , could I get a review for the @tabgok , can I get a review on the... non-IDM IDM things? |
This PR renames the unreleased, to-be-externally-facing Test Visibility-related methods/classes/etc to use some variations of "test visibility"-themed names to reflect the fact that the CI Visibility product is now known as Test Visibility.
It also takes several pieces that were previously public and creates a new, internal, test visibility API that extends the external one.
Notably:
CIVisibility
service is imported)ci_visibility.*
totest_visibility.*
CI*
API classes are renamed toTest*
*ItemId
classes to a separate file to reduce circular dependencies between external and internal APICIVisibility*
API classes renamed toTestVisibility
test_visibility
integration config (renamed fromci_visibility
)One important note is that
DD_CIVISIBILITY_*
environment variables remain untouched. This does lead to the incongruity of configuring Test Visibility with CI Visibility-named vars.There are no release notes because the public API components are unreleased and marked as subject to change in comments.
Checklist
Reviewer Checklist