chore(ci_visibility): don't log exception when codeowners can't be loaded

[romainkomorndatadog]

Reverts the Codeowners.__init__() behavior introduced in #10094 which changed the exception being caught by the CIVisibility service when instantiating Codeowners(), resulting in undesirable log messages.

Codeowners.__init__() raising a ValueError exception, caught by the sole caller (CIVisibility.__init__()).

The of() behavior is maintained and the caller is updated to check for [] as an indication that no codeowner was found.

There is no release note as #10094 was only backported into 2.12.

As a bonus, type hints are converted from comments to annotations.

Checklist

• PR author has checked that all the criteria below are met
• The PR description includes an overview of the change
• The PR description articulates the motivation for the change
• The change includes tests OR the PR description describes a testing strategy
• The PR description notes risks associated with the change, if any
• Newly-added code is easy to change
• The change follows the library release note guidelines
• The change includes or references documentation updates if necessary
• Backport labels are set (if applicable)

Reviewer Checklist

• Reviewer has checked that all the criteria below are met
• Title is accurate
• All changes are related to the pull request's stated goal
• Avoids breaking API changes
• Testing strategy adequately addresses listed risks
• Newly-added code is easy to change
• Release note makes sense to a user of the library
• If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
• Backport labels are set in a manner that is consistent with the release branch maintenance policy

[github-actions]

CODEOWNERS have been resolved as:

ddtrace/internal/ci_visibility/recorder.py                              @DataDog/ci-app-libraries
ddtrace/internal/codeowners.py                                          @DataDog/apm-core-python @datadog/ci-app-libraries

[datadog-dd-trace-py-rkomorn]

Datadog Report

Branch report: romain.komorn/chore/stop_logging_warnings_for_codeowners
Commit report: a3a6b2f
Test service: dd-trace-py

✅ 0 Failed, 288 Passed, 1914 Skipped, 4m 58.02s Total Time

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-08-29 08:12:57

Comparing candidate commit a3a6b2f in PR branch romain.komorn/chore/stop_logging_warnings_for_codeowners with baseline commit 03f3219 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

[romainkomorndatadog]

Adding @brettlangdon and @emmettbutler as reviewers since you two seem to have the most knowledge behind the original "remove crashing behavior" work.

[romainkomorndatadog]

Added a3a6b2f to make things a little more resilient.