Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci_visibility): only store longrepr as XFAIL_REASON if the test is an xfail #10379

Conversation

romainkomorndatadog
Copy link
Collaborator

@romainkomorndatadog romainkomorndatadog commented Aug 26, 2024

This primarily addresses warning messages that would be shown if a test was marked as skipped by ITR, but also xfailed.

This would've resulted in a log warning that the test item was already finished, which would result in the tag setting being a noop.

No changelog is added because this plugin is not yet released.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@romainkomorndatadog romainkomorndatadog added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 26, 2024
@romainkomorndatadog romainkomorndatadog self-assigned this Aug 26, 2024
@romainkomorndatadog romainkomorndatadog requested a review from a team as a code owner August 26, 2024 13:15
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/contrib/pytest/_plugin_v2.py                                    @DataDog/ci-app-libraries

@pr-commenter
Copy link

pr-commenter bot commented Aug 26, 2024

Benchmarks

Benchmark execution time: 2024-08-26 13:49:30

Comparing candidate commit f0f45f7 in PR branch romain.komorn/SDTEST-225/dont_readd_tag_for_xfail_skips with baseline commit 262b9d6 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@romainkomorndatadog romainkomorndatadog merged commit 1b090af into main Aug 27, 2024
159 of 161 checks passed
@romainkomorndatadog romainkomorndatadog deleted the romain.komorn/SDTEST-225/dont_readd_tag_for_xfail_skips branch August 27, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants