Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): fix idna package test #10377

Merged
merged 16 commits into from
Aug 26, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/appsec/iast_packages/test_packages.py
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,6 @@ def uninstall(self, python_cmd):
"xn--eckwd4c7c.xn--zckzah",
import_module_to_validate="idna.codec",
test_propagation=True,
fixme_propagation_fails=False,
),
PackageForTesting(
"importlib-resources",
Expand Down Expand Up @@ -885,7 +884,7 @@ def _assert_propagation_results(response, package):
if package.fixme_propagation_fails is not None:
if result_ok:
if package.fixme_propagation_fails: # For packages that are reliably failing
pytest.fail(
pytest.xfail(
"FIXME: Test passed unexpectedly, consider changing to fixme_propagation_fails=False for package %s"
% package.name
)
Expand Down
Loading