Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(di): simplify context capturing API #10354

Conversation

P403n1x87
Copy link
Contributor

We clean-up the internal context capturing API after the recent changes that have introduced support for local variables in function probes and the exposure of globals to expression/condition evaluations.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@P403n1x87 P403n1x87 added changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger labels Aug 23, 2024
@P403n1x87 P403n1x87 force-pushed the refactor/di-simplify-capture-context-api branch from 7805694 to c5b32a9 Compare August 23, 2024 15:22
@P403n1x87 P403n1x87 marked this pull request as ready for review August 23, 2024 15:46
@P403n1x87 P403n1x87 requested a review from a team as a code owner August 23, 2024 15:46
We clean-up the internal context capturing API after the recent changes
that have introduced support for local variables in function probes and
the exposure of globals to expression/condition evaluations.
@P403n1x87 P403n1x87 force-pushed the refactor/di-simplify-capture-context-api branch from c5b32a9 to 631f7bc Compare August 24, 2024 14:43
@P403n1x87 P403n1x87 enabled auto-merge (squash) August 24, 2024 14:53
@P403n1x87 P403n1x87 closed this Aug 29, 2024
auto-merge was automatically disabled August 29, 2024 09:16

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant