Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): let more tools know that we use 120 character per line #10339

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

apiarian-datadog
Copy link
Contributor

@apiarian-datadog apiarian-datadog commented Aug 22, 2024

Some instances of flake8 expect to find their max-line-length config in setup.cfg.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

setup.cfg                                                               @DataDog/python-guild

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Aug 22, 2024

Datadog Report

Branch report: aleksandr.pasechnik/tweak-setup-cfg
Commit report: 757eefe
Test service: dd-trace-py

✅ 0 Failed, 141107 Passed, 1669 Skipped, 8h 36m 23.79s Total duration (17.61s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Aug 22, 2024

Benchmarks

Benchmark execution time: 2024-08-26 14:31:54

Comparing candidate commit 757eefe in PR branch aleksandr.pasechnik/tweak-setup-cfg with baseline commit ee75b12 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@apiarian-datadog apiarian-datadog added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 23, 2024
@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/tweak-setup-cfg branch from 0079e1d to a06f03e Compare August 23, 2024 14:28
@taegyunkim taegyunkim force-pushed the aleksandr.pasechnik/tweak-setup-cfg branch from a06f03e to 757eefe Compare August 26, 2024 13:51
@taegyunkim taegyunkim enabled auto-merge (squash) August 26, 2024 13:52
@taegyunkim taegyunkim merged commit 39e47a8 into main Aug 26, 2024
251 of 252 checks passed
@taegyunkim taegyunkim deleted the aleksandr.pasechnik/tweak-setup-cfg branch August 26, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants