-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: automate package version updates #10264
Conversation
|
BenchmarksBenchmark execution time: 2024-08-23 17:32:13 Comparing candidate commit 0af3eb6 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic makes sense to me. I have a couple of non-blocking nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great progress. I mentioned a bit of complexity that will need to be addressed, but I don't think it needs to happen before this change is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
(Defer to the python experts for python code review 😄)
I just had a few nitpicks on the generated PR title/body - real small stuff
scripts/freshvenvs
to generate a list of "outdated" packages (packages where we don't test the full range from MIN_SUPPORTED_VERSION to MAX_SUPPORTED_VERSION)- Can adjust frequency / time - currently Sunday midnight
Testing:
Github Actions workflows: https://github.com/DataDog/dd-trace-py/actions/workflows/generate-package-versions.yml
Example PR: #10333
Checklist
Reviewer Checklist