MQ TEST - fix(telemetry): fix integration name telemetry after refactoring to internal #10177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikayasuda
requested review from
emmettbutler
and removed request for
a team and
emmettbutler
|
/merge |
|
|
|
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
|
/remove |
|
🚂 Devflow: |
|
This merge request was unqueued If you need support, contact us on Slack #devflow! |
This is the first part of the effort to add the `server.address` tag to database clients. Every db span _must_ have a `server.address` tag based on the [OpenTelemetry definition](https://opentelemetry.io/docs/specs/semconv/general/attributes/#server-attributes), as per convention [for database spans](https://opentelemetry.io/docs/specs/semconv/database/database-spans/). On the client side, it should match the remote service name; on the server side it should represent the local service name as seen externally on clients. This modifies the following: - aiomysql - asyncpg - cassandra - django - elasticsearch - flask (cache) - mariadb - mysql - mysqldb - pymongo - pymemcache - pymysql - snowflake - sqlalchemy - vertica The new spans: <img width="680" alt="Screenshot 2024-08-07 at 12 43 38 PM" src="https://github.com/user-attachments/assets/a47573c1-fdad-4318-a7ad-af24a25cc40b"> ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Emmett Butler <[email protected]>
BenchmarksBenchmark execution time: 2024-08-12 16:48:00 Comparing candidate commit 5b16a02 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics. |
## Description Micro benchmarks for each aspect, comparing the patched and unpatched performance. Note: this moves some IAST fixtures from `tests.*` to `benchamarks.*` because the environment under which the benchmarks are run doesn't have access to `tests.*` (but tests have access to benchmarks dirs). ## Checklist - [X] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Signed-off-by: Juanjo Alvarez <[email protected]>
Datadog ReportBranch report: ✅ 0 Failed, 1893 Passed, 801 Skipped, 7m 29.19s Total duration (2m 19.71s time saved) |
erikayasuda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS A TEST PR.
It can be merged to
test-mq-main, but this is primarily to test the merge queue functionality for our repo.Original PR this is replicating for the main branch: #10172
Checklist
Reviewer Checklist