Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove setuptools dependency (#9931) [backport 2.10] #10035

Closed
wants to merge 2 commits into from

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Aug 1, 2024

This PR removes the need to have setuptools listed as a dependency for our package.

Our code does not actually need setuptools or pkg_resources for anything. The only places where it is used it is checking if the user is using setuptools (e.g. ddtrace/sourcecode/setuptools_auto), or in our test suite.

An added benefit here is for our lib-injection/OCI images this removed 7+mb per-python/arch combination by removing setuptools dependency (saves ~75mb or 20% savings).

  • checklist

Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to add a release note.

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Aug 1, 2024

Datadog Report

Branch report: backport-9931-to-2.10
Commit report: 6db1d00
Test service: dd-trace-py

❌ 258 Failed (0 Known Flaky), 175241 Passed, 1247 Skipped, 12h 38m 26.73s Total duration (16m 32.28s time saved)

❌ Failed Tests (258)

This report shows up to 5 failed tests.

  • test_data_streams_sns_to_sqs - test.py - Details

    Expand for error
     Subprocess Test "python -m unittest tests.contrib.botocore.test.BotocoreTest.test_data_streams_sns_to_sqs" Failed (exit code 1):
     E
     ======================================================================
     ERROR: test_data_streams_sns_to_sqs (tests.contrib.botocore.test.BotocoreTest)
     ----------------------------------------------------------------------
     Traceback (most recent call last):
       File "/root/project/.riot/venv_py3816_mock_pytest_pytest-mock_coverage_pytest-cov_opentracing_hypothesis6451_moto[all]50_pytest-randomly_botocore_vcrpy/lib/python3.8/site-packages/moto/core/models.py", line 150, in wrapper
         result = func(*args, **kwargs)
       File "/root/project/tests/contrib/botocore/test.py", line 88, in setUp
         for queue_url in self.sqs_client.list_queues().get("QueueUrls", []):
     ...
    
  • test_data_streams_sns_to_sqs - test.py - Details

    Expand for error
     Subprocess Test "python -m unittest tests.contrib.botocore.test.BotocoreTest.test_data_streams_sns_to_sqs" Failed (exit code 1):
     E
     ======================================================================
     ERROR: test_data_streams_sns_to_sqs (tests.contrib.botocore.test.BotocoreTest)
     ----------------------------------------------------------------------
     Traceback (most recent call last):
       File "/root/project/.riot/venv_py3916_mock_pytest_pytest-mock_coverage_pytest-cov_opentracing_hypothesis6451_moto[all]50_pytest-randomly_botocore~113_vcrpy/lib/python3.9/site-packages/moto/core/models.py", line 150, in wrapper
         result = func(*args, **kwargs)
       File "/root/project/tests/contrib/botocore/test.py", line 88, in setUp
         for queue_url in self.sqs_client.list_queues().get("QueueUrls", []):
     ...
    
  • test_data_streams_sns_to_sqs_raw_delivery - test.py - Details

    Expand for error
     Subprocess Test "python -m unittest tests.contrib.botocore.test.BotocoreTest.test_data_streams_sns_to_sqs_raw_delivery" Failed (exit code 1):
     E
     ======================================================================
     ERROR: test_data_streams_sns_to_sqs_raw_delivery (tests.contrib.botocore.test.BotocoreTest)
     Moto doesn't currently handle raw delivery message handling quite correctly.
     ----------------------------------------------------------------------
     Traceback (most recent call last):
       File "/root/project/.riot/venv_py3916_mock_pytest_pytest-mock_coverage_pytest-cov_opentracing_hypothesis6451_moto[all]50_pytest-randomly_botocore~113_vcrpy/lib/python3.9/site-packages/moto/core/models.py", line 150, in wrapper
         result = func(*args, **kwargs)
       File "/root/project/tests/contrib/botocore/test.py", line 88, in setUp
     ...
    
  • test_data_streams_sns_to_sqs_raw_delivery - test.py - Details

    Expand for error
     Subprocess Test "python -m unittest tests.contrib.botocore.test.BotocoreTest.test_data_streams_sns_to_sqs_raw_delivery" Failed (exit code 1):
     E
     ======================================================================
     ERROR: test_data_streams_sns_to_sqs_raw_delivery (tests.contrib.botocore.test.BotocoreTest)
     Moto doesn't currently handle raw delivery message handling quite correctly.
     ----------------------------------------------------------------------
     Traceback (most recent call last):
       File "/root/project/.riot/venv_py3816_mock_pytest_pytest-mock_coverage_pytest-cov_opentracing_hypothesis6451_moto[all]50_pytest-randomly_botocore_vcrpy/lib/python3.8/site-packages/moto/core/models.py", line 150, in wrapper
         result = func(*args, **kwargs)
       File "/root/project/tests/contrib/botocore/test.py", line 88, in setUp
     ...
    
  • test_data_streams_sqs - test.py - Details

    Expand for error
     Subprocess Test "python -m unittest tests.contrib.botocore.test.BotocoreTest.test_data_streams_sqs" Failed (exit code 1):
     E
     ======================================================================
     ERROR: test_data_streams_sqs (tests.contrib.botocore.test.BotocoreTest)
     ----------------------------------------------------------------------
     Traceback (most recent call last):
       File "/root/project/.riot/venv_py3916_mock_pytest_pytest-mock_coverage_pytest-cov_opentracing_hypothesis6451_moto[all]50_pytest-randomly_botocore~113_vcrpy/lib/python3.9/site-packages/moto/core/models.py", line 150, in wrapper
         result = func(*args, **kwargs)
       File "/root/project/tests/contrib/botocore/test.py", line 88, in setUp
         for queue_url in self.sqs_client.list_queues().get("QueueUrls", []):
     ...
    

@pr-commenter
Copy link

pr-commenter bot commented Aug 1, 2024

Benchmarks

Benchmark execution time: 2024-08-06 18:34:45

Comparing candidate commit 6db1d00 in PR branch backport-9931-to-2.10 with baseline commit 93089e0 in branch 2.10.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.

@romainkomorndatadog romainkomorndatadog added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 2, 2024
@emmettbutler emmettbutler changed the title chore: remove setuptools dependency (#9931) chore: remove setuptools dependency (#9931) [backport 2.10] Aug 2, 2024
@emmettbutler
Copy link
Collaborator Author

@brettlangdon this is a backport change - maybe we should add the release note in a PR against main?

brettlangdon and others added 2 commits August 6, 2024 13:41
This PR removes the need to have `setuptools` listed as a dependency for
our package.

Our code does not actually need `setuptools` or `pkg_resources` for
anything. The only places where it is used it is checking if the user is
using setuptools (e.g. `ddtrace/sourcecode/setuptools_auto`), or in our
test suite.

An added benefit here is for our lib-injection/OCI images this removed
7+mb per-python/arch combination by removing `setuptools` dependency
(saves ~75mb or 20% savings).

[](https://datadoghq.atlassian.net/browse/APMON-1292)

- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 08ed199)
@romainkomorndatadog romainkomorndatadog deleted the backport-9931-to-2.10 branch September 27, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants