Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): export lock acquire/release call location and variable name [backport 2.10] #10031

Merged
merged 6 commits into from
Aug 2, 2024

Commits on Aug 1, 2024

  1. fix(profiling): export lock acquire/release call location and variabl…

    …e name (#9615)
    
    We used to export "<filename>:<line_number>" for the name of a lock.
    Whenever lock is initialized, we traverse the stack frame to populate
    these. However, we can't get the variable name of the lock as we haven't
    yet fully initialized and assigned it to a variable.
    
    Now we traverse the frame whenever `_acquire/_release` is called to get
    the caller information. Also, when `_acquire` is called for the first
    time, we inspect local and global variables in the caller frame to find
    the name of this lock variable. With
    `DD_PROFILING_LOCK_NAME_INSPECT_DIR` enabled, the lock profiler also
    inspects attributes of local and global variables to find the name of
    the lock. This behavior can be turned off with the flag.
    
    - [x] Change(s) are motivated and described in the PR description
    - [x] Testing strategy is described if automated tests are not included
    in the PR
    - [x] Risks are described (performance impact, potential for breakage,
    maintainability)
    - [x] Change is maintainable (easy to change, telemetry, documentation)
    - [x] [Library release note
    guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
    are followed or label `changelog/no-changelog` is set
    - [x] Documentation is included (in-code, generated user docs, [public
    corp docs](https://github.com/DataDog/documentation/))
    - [x] Backport labels are set (if
    [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
    - [x] If this PR changes the public interface, I've notified
    `@DataDog/apm-tees`.
    
    - [x] Title is accurate
    - [x] All changes are related to the pull request's stated goal
    - [x] Description motivates each change
    - [x] Avoids breaking
    [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
    changes
    - [x] Testing strategy adequately addresses listed risks
    - [x] Change is maintainable (easy to change, telemetry, documentation)
    - [x] Release note makes sense to a user of the library
    - [x] Author has acknowledged and discussed the performance implications
    of this PR as reported in the benchmarks PR comment
    - [x] Backport labels are set in a manner that is consistent with the
    [release branch maintenance
    policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
    taegyunkim committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    39017f1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    53521de View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0c581ba View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4a5eabf View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Configuration menu
    Copy the full SHA
    88f94aa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1197bdc View commit details
    Browse the repository at this point in the history