-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci_visibility): don't rely on git in pytest plugin [backport 2.8] #10024
Conversation
Fixes an issue introduced by #9586 and reported in #9981 where the pytest plugin would crash if the `git` binary was absent. The workspace is instead grabbed from the `CIVisibility` service's tags (via a new getter classmethod). In order for the variable to persist through to the `pytest_terminal_summary` hook, it is moved from being stashed on the pytest `session` object to the nested `config` object (which itself is passed to `pytest_terminal_summary`). For improved testability, a function to get the location of the `git` binary's passed, using `@cached()` to avoid re-fetching the path each time we call `git`. - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: erikayasuda <[email protected]> (cherry picked from commit c460441)
Datadog ReportBranch report: ❌ 11 Failed (1 Known Flaky), 169635 Passed, 1487 Skipped, 12h 37m 36.79s Total duration (28m 3.06s time saved) ❌ Failed Tests (11)
New Flaky Tests (1)
⌛ Performance Regressions vs Default Branch (2) |
Backport c460441 from #9989 to 2.8.
Fixes an issue introduced by #9586 and reported in #9981 where the pytest plugin would crash if the
git
binary was absent.The workspace is instead grabbed from the
CIVisibility
service's tags (via a new getter classmethod).In order for the variable to persist through to the
pytest_terminal_summary
hook, it is moved from being stashed on the pytestsession
object to the nestedconfig
object (which itself is passed topytest_terminal_summary
).For improved testability, a function to get the location of the
git
binary's passed, using@cached()
to avoid re-fetching the path each time we callgit
.Checklist
Reviewer Checklist