Merge branch '2.12' into backport-10423-to-2.12

ddtrace/internal/module.py

@@ -201,7 +201,7 @@ def call_back(self, module: ModuleType) -> None:
         except (AttributeError, TypeError):
             pass
         try:
-            module.spec.loader = self.loader
+            object.__getattribute__(module, "spec").loader = self.loader
         except (AttributeError, TypeError):
             pass
 
@@ -313,7 +313,10 @@ def get_code(_loader, fullname):
                     exception_hook(self, module)
                 raise
 
-        self.call_back(module)
+        try:
+            self.call_back(module)
+        except Exception:
+            log.exception("Failed to call back on module %s", module)
 
 
 class BaseModuleWatchdog(abc.ABC):

releasenotes/notes/fix-module-callback-no-side-effects-df422ae52b87772d.yaml

@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+    Fix for a side-effect issue with module import callbacks that could cause
+    a runtime exception.

tests/internal/side_effect_module.py

@@ -0,0 +1,11 @@
+import sys
+from types import ModuleType
+
+
+class SideEffectModule(ModuleType):
+    def __getattribute__(self, name):
+        if name in {"spec"}:
+            raise RuntimeError("Attribute lookup side effect")
+
+
+sys.modules[__name__].__class__ = SideEffectModule

tests/internal/test_module.py

@@ -526,3 +526,10 @@ def test_module_watchdog_reloads_dont_cause_errors():
     sys.setrecursionlimit(1000)
     for _ in range(sys.getrecursionlimit() * 2):
         reload(ns_module)
+
+
+@pytest.mark.subprocess(ddtrace_run=True)
+def test_module_import_side_effect():
+    # Test that we can import a module that raises an exception during specific
+    # attribute lookups.
+    import tests.internal.side_effect_module  # noqa:F401