Skip to content

Commit

Permalink
ci(tornado): run the tornado suite when the futures contrib changes (#…
Browse files Browse the repository at this point in the history
…9656)

This change updates the suitespec to run the tornado suite on pull
requests that change `contrib/futures`. This is necessary because
#9588 introduced a
[failure](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/64311/workflows/c67de0aa-58b3-42ca-8f52-68d6ea9b45a8/jobs/3979086)
in that suite that was only discovered post-merge.

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.

## Reviewer Checklist

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
  • Loading branch information
emmettbutler authored Jun 26, 2024
1 parent 4524ae1 commit c9a16ed
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tests/.suitespec.json
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,7 @@
"@llmobs",
"@serverless",
"@remoteconfig",
"@futures",
"tests/tracer/*",
"tests/snapshots/test_*"
],
Expand Down Expand Up @@ -1278,6 +1279,7 @@
"@contrib",
"@tracing",
"@tornado",
"@futures",
"tests/contrib/tornado/*"
],
"rediscluster": [
Expand Down

0 comments on commit c9a16ed

Please sign in to comment.