Skip to content

Commit

Permalink
ci: fix flaky tracer tests (#10436)
Browse files Browse the repository at this point in the history
Previous PR fixed flakiness in one part of this test, but there is a
remaining bit which is also flaky.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
  • Loading branch information
brettlangdon authored Aug 29, 2024
1 parent e1a9037 commit a941420
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/tracer/test_rate_limiter.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,8 @@ def test_rate_limiter_effective_rate_starting_rate(time_window):
assert limiter.current_window_ns == (now_ns + time_window)
assert limiter.prev_window_rate == 0.5

# Gap of 1.9999 seconds, same window
time_ns = now_ns + (1.9999 * time_window)
# Gap of 1.85 seconds, same window
time_ns = now_ns + (1.85 * time_window)
with mock.patch("ddtrace.internal.rate_limiter.compat.monotonic_ns", return_value=time_ns):
assert limiter.is_allowed() is False
assert limiter.effective_rate == 0.5
Expand Down

0 comments on commit a941420

Please sign in to comment.