Skip to content

Commit

Permalink
wip
Browse files Browse the repository at this point in the history
  • Loading branch information
quinna-h committed Oct 7, 2024
1 parent 0d5e862 commit a3ec11d
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 0 deletions.
12 changes: 12 additions & 0 deletions tests/contrib/mysqldb/test_mysqldb.py
Original file line number Diff line number Diff line change
Expand Up @@ -667,6 +667,18 @@ def test_unspecified_service_v1(self):
spans = tracer.pop()

assert spans[0].service == DEFAULT_SPAN_SERVICE_NAME

@TracerTestCase.run_in_subprocess(env_overrides=dict())
def test_service_override(self):
with self.override_config("mysqldb", dict(service='mysqldb-service')):
conn, tracer = self._get_conn_tracer()
cursor = conn.cursor()
cursor.execute("SELECT 1")
rows = cursor.fetchall()
assert len(rows) == 1
spans = tracer.pop()

assert spans[0].service == "mysqldb-service"

def test_trace_connect(self):
# No span when trace_connect is False (the default)
Expand Down
16 changes: 16 additions & 0 deletions tests/contrib/pyodbc/test_pyodbc.py
Original file line number Diff line number Diff line change
Expand Up @@ -366,3 +366,19 @@ def test_schematized_operation_name_v1(self):
assert span.name == "pyodbc.query", "Expected operation name to be 'pyodbc.query' but was '{}'".format(
span.name
)

@TracerTestCase.run_in_subprocess(env_overrides=dict())
def test_override_service_name(self):
from ddtrace import config

config.pyodbc["service"] = "pyodbc-service"

conn, tracer = self._get_conn_tracer()

conn.rollback()
spans = tracer.pop()
assert len(spans) == 1
span = spans[0]
assert span.service == "pyodbc-service", "Expected service name to be 'pyodbc-service' but was '{}'".format(
span.service
)

0 comments on commit a3ec11d

Please sign in to comment.