Skip to content

Commit

Permalink
ci(profiling): adjust expectation (#9191)
Browse files Browse the repository at this point in the history
This change updates a line-number expectation in the profiling test
suite to match reality.

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.

## Reviewer Checklist

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
  • Loading branch information
emmettbutler authored May 7, 2024
1 parent e5cddcd commit 666d174
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions tests/profiling/collector/test_threading.py
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,12 @@ def play_with_lock():
# It's called through pytest so I'm sure it's gonna be that long, right?
assert len(event.frames) > 3
assert event.nframes > 3
assert event.frames[0] == ("tests/profiling/collector/test_threading.py", 238, "play_with_lock", "")
assert event.frames[0] == (
"tests/profiling/collector/test_threading.py",
238,
"play_with_lock",
"",
), event.frames
assert event.sampling_pct == 100
break
else:
Expand All @@ -268,7 +273,12 @@ def play_with_lock():
# It's called through pytest so I'm sure it's gonna be that long, right?
assert len(event.frames) > 3
assert event.nframes > 3
assert event.frames[0] == ("tests/profiling/collector/test_threading.py", 238, "play_with_lock", "")
assert event.frames[0] == (
"tests/profiling/collector/test_threading.py",
239,
"play_with_lock",
"",
), event.frames
assert event.sampling_pct == 100
break
else:
Expand Down

0 comments on commit 666d174

Please sign in to comment.