Skip to content

Commit

Permalink
chore(iast): early return if nullptr for type checks (#10799)
Browse files Browse the repository at this point in the history
Code Security: early return for type checks if comparing `None`

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
  • Loading branch information
gnufede authored Sep 25, 2024
1 parent 42a4387 commit 45c891b
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions ddtrace/appsec/_iast/_taint_tracking/Utils/StringUtils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,9 @@ get_pyobject_size(PyObject* obj)
bool
PyIOBase_Check(const PyObject* obj)
{
if (!obj)
return false;

try {
return py::isinstance((PyObject*)obj, safe_import("_io", "_IOBase"));
} catch (py::error_already_set& err) {
Expand All @@ -158,6 +161,9 @@ PyIOBase_Check(const PyObject* obj)
bool
PyReMatch_Check(const PyObject* obj)
{
if (!obj)
return false;

try {
return py::isinstance((PyObject*)obj, safe_import("re", "Match"));
} catch (py::error_already_set& err) {
Expand Down

0 comments on commit 45c891b

Please sign in to comment.