Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-6200: Add Tab semantics mapper #2378

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

ambushwork
Copy link
Contributor

What does this PR do?

Add Tab semantics mapper to resolve tab component to wireframe for Session Replay

Known issue:
We are not able to have the correct color for the image in the tab bar, because we retrieve directly Bitmap, not a tintable drawable.

Motivation

RUM-6200

Demo

Sample App Session Replay
image image

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 62.06897% with 11 lines in your changes missing coverage. Please review.

Project coverage is 69.69%. Comparing base (ea89435) to head (86d9761).
Report is 2 commits behind head on feature/sr_compose.

Files with missing lines Patch % Lines
...ternal/mappers/semantics/TabSemanticsNodeMapper.kt 73.91% 3 Missing and 3 partials ⚠️
...ionreplay/compose/internal/utils/SemanticsUtils.kt 0.00% 5 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/sr_compose    #2378      +/-   ##
======================================================
+ Coverage               69.61%   69.69%   +0.08%     
======================================================
  Files                     771      772       +1     
  Lines                   28690    28719      +29     
  Branches                 4877     4885       +8     
======================================================
+ Hits                    19971    20014      +43     
+ Misses                   7361     7346      -15     
- Partials                 1358     1359       +1     
Files with missing lines Coverage Δ
...rnal/mappers/semantics/SemanticsWireframeMapper.kt 81.58% <100.00%> (+0.50%) ⬆️
...ionreplay/compose/internal/utils/SemanticsUtils.kt 1.20% <0.00%> (-0.08%) ⬇️
...ternal/mappers/semantics/TabSemanticsNodeMapper.kt 73.91% <73.91%> (ø)

... and 25 files with indirect coverage changes

@ambushwork ambushwork marked this pull request as ready for review November 6, 2024 12:38
@ambushwork ambushwork requested review from a team as code owners November 6, 2024 12:38
0xnm
0xnm previously approved these changes Nov 6, 2024
@ambushwork
Copy link
Contributor Author

unit test added

@ambushwork ambushwork requested a review from 0xnm November 6, 2024 15:00
@ambushwork ambushwork merged commit 3835e65 into feature/sr_compose Nov 7, 2024
24 checks passed
@ambushwork ambushwork deleted the yl/compose/add-tab-mapper branch November 7, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants