Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CompoundButton mapper drawable clone issue #2365

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

ambushwork
Copy link
Contributor

What does this PR do?

This PR is a follow-up of this PR.

There were still some mapper copying their drawable before retrieving the cache, especially in CompoundButton mappers,

So this PR cleans up the related issue.

Motivation

RUM-6897

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork force-pushed the yl/sr-mnt/fix-checkable-image-cache branch from 7eaf9cc to 5e4afc8 Compare October 31, 2024 15:05
@ambushwork ambushwork marked this pull request as ready for review October 31, 2024 16:57
@ambushwork ambushwork requested review from a team as code owners October 31, 2024 16:57
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 70.33%. Comparing base (b83e7b6) to head (6349277).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...lay/internal/recorder/mapper/SwitchCompatMapper.kt 25.00% 6 Missing ⚠️
.../internal/recorder/mapper/CheckedTextViewMapper.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2365      +/-   ##
===========================================
+ Coverage    70.31%   70.33%   +0.02%     
===========================================
  Files          744      744              
  Lines        27719    27721       +2     
  Branches      4631     4630       -1     
===========================================
+ Hits         19490    19496       +6     
- Misses        6939     6942       +3     
+ Partials      1290     1283       -7     
Files with missing lines Coverage Δ
...l/recorder/mapper/CheckableCompoundButtonMapper.kt 37.50% <100.00%> (+3.12%) ⬆️
...nternal/recorder/mapper/CheckableTextViewMapper.kt 63.16% <100.00%> (+3.16%) ⬆️
.../internal/recorder/mapper/CheckedTextViewMapper.kt 75.00% <0.00%> (-3.12%) ⬇️
...lay/internal/recorder/mapper/SwitchCompatMapper.kt 88.24% <25.00%> (ø)

... and 24 files with indirect coverage changes

@ambushwork ambushwork force-pushed the yl/sr-mnt/fix-checkable-image-cache branch from 5e4afc8 to 6349277 Compare November 4, 2024 09:58
@ambushwork ambushwork merged commit b1d6ebb into develop Nov 4, 2024
24 checks passed
@ambushwork ambushwork deleted the yl/sr-mnt/fix-checkable-image-cache branch November 4, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants