Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-5814 Provide device and os info into local spans metadata #2347

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

mariusc83
Copy link
Collaborator

@mariusc83 mariusc83 commented Oct 24, 2024

What does this PR do?

After a short analysis on our local traces vs the traces created by RUM backend based on our RUM resource events we realized that we are missing some content for the local ones: device and os informations.
In this PR we are aligning the information in the local traces vs RUM backend traces by adding the device and os information into the local traces meta.

Please note that in order to keep schemas aligned I added these new properties also into the benchmark module span-schema.json but made them optional as right now the benchmark module is not using these (we might need it later).

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 self-assigned this Oct 24, 2024
@mariusc83 mariusc83 force-pushed the mconstantin/rum-5814/fix-span-data-inconsitency branch 3 times, most recently from 97ff259 to d72633d Compare October 25, 2024 08:13
@mariusc83 mariusc83 marked this pull request as ready for review October 25, 2024 08:31
@mariusc83 mariusc83 requested review from a team as code owners October 25, 2024 08:31
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.40%. Comparing base (fcfbbab) to head (f6ef7b5).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...al/domain/event/CoreTracerSpanToSpanEventMapper.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2347      +/-   ##
===========================================
+ Coverage    70.33%   70.40%   +0.06%     
===========================================
  Files          740      741       +1     
  Lines        27633    27643      +10     
  Branches      4628     4624       -4     
===========================================
+ Hits         19435    19460      +25     
+ Misses        6909     6901       -8     
+ Partials      1289     1282       -7     
Files with missing lines Coverage Δ
...trace/internal/domain/event/BaseSpanEventMapper.kt 100.00% <100.00%> (ø)
...e/internal/domain/event/DdSpanToSpanEventMapper.kt 93.62% <100.00%> (+5.09%) ⬆️
...al/domain/event/CoreTracerSpanToSpanEventMapper.kt 93.02% <83.33%> (+1.27%) ⬆️

... and 25 files with indirect coverage changes

import com.datadog.android.api.context.UserInfo
import com.datadog.android.trace.model.SpanEvent

internal abstract class BaseSpanEventMapper {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Maybe we could make this a BaseSpanEventMapper<T>: ContextAwareMapper<T, SpanEvent>, as it's only used on classes that extend this, and the purpose of this class is linked with creating SpanEvent content.

@mariusc83 mariusc83 force-pushed the mconstantin/rum-5814/fix-span-data-inconsitency branch from d72633d to f6ef7b5 Compare October 25, 2024 15:31
@mariusc83 mariusc83 merged commit 112e00f into develop Oct 28, 2024
24 checks passed
@mariusc83 mariusc83 deleted the mconstantin/rum-5814/fix-span-data-inconsitency branch October 28, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants