Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-6375: Force single core for session replay #2324

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

jonathanmos
Copy link
Contributor

@jonathanmos jonathanmos commented Oct 16, 2024

What does this PR do?

Allow session replay to run on only one core at a time. Attempting to start sr on more cores will send telemetry.

Motivation

It probably doesn't make sense for session replay to run on multiple cores.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@jonathanmos jonathanmos force-pushed the jmoskovich/rum-6375/force-single-core branch from b70a0a4 to 4fbbd96 Compare October 16, 2024 14:29
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.37%. Comparing base (992020c) to head (0cf1490).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...tadog/android/core/internal/NoOpInternalSdkCore.kt 0.00% 1 Missing ⚠️
...com/datadog/android/sessionreplay/SessionReplay.kt 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2324      +/-   ##
===========================================
- Coverage    70.42%   70.37%   -0.05%     
===========================================
  Files          740      740              
  Lines        27593    27604      +11     
  Branches      4622     4624       +2     
===========================================
- Hits         19430    19425       -5     
- Misses        6878     6888      +10     
- Partials      1285     1291       +6     
Files with missing lines Coverage Δ
...src/main/kotlin/com/datadog/android/api/SdkCore.kt 25.00% <ø> (ø)
...n/com/datadog/android/core/internal/DatadogCore.kt 82.27% <100.00%> (+0.08%) ⬆️
...tadog/android/core/internal/NoOpInternalSdkCore.kt 8.97% <0.00%> (-0.12%) ⬇️
...com/datadog/android/sessionreplay/SessionReplay.kt 68.42% <90.00%> (+6.35%) ⬆️

... and 28 files with indirect coverage changes

@jonathanmos jonathanmos force-pushed the jmoskovich/rum-6375/force-single-core branch 2 times, most recently from 361cf42 to a7e2344 Compare October 20, 2024 07:41
@jonathanmos jonathanmos marked this pull request as ready for review October 20, 2024 10:12
@jonathanmos jonathanmos requested review from a team as code owners October 20, 2024 10:12
@jonathanmos jonathanmos force-pushed the jmoskovich/rum-6375/force-single-core branch from e5194c4 to 154134f Compare October 22, 2024 13:04
@jonathanmos jonathanmos force-pushed the jmoskovich/rum-6375/force-single-core branch from 154134f to 0cf1490 Compare October 23, 2024 07:53
@jonathanmos jonathanmos merged commit 8fb02ed into develop Oct 23, 2024
24 checks passed
@jonathanmos jonathanmos deleted the jmoskovich/rum-6375/force-single-core branch October 23, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants