Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-6219: Add Image and TextAndInput privacy overrides #2312

Merged

Conversation

jonathanmos
Copy link
Contributor

@jonathanmos jonathanmos commented Oct 8, 2024

What does this PR do?

Adds privacy overrides for images and textAndInput.
Api example:

view.setSessionReplayImagePrivacy(privacy: ImagePrivacy?)
view.setSessionReplayTextAndInputPrivacy(privacy: TextAndInputPrivacy?)

These privacy overrides work on nearest parent - so if you override the privacy on a viewgroup, it should be propagated to the children unless they have their own override.

Motivation

Part of the fine grained masking effort.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@jonathanmos jonathanmos force-pushed the jmoskovich/rum-6219/text-image-privacy-overrides branch from 28f37ed to 83cf711 Compare October 8, 2024 08:30
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.42%. Comparing base (f16a5d4) to head (9124b62).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2312      +/-   ##
===========================================
+ Coverage    70.33%   70.42%   +0.09%     
===========================================
  Files          738      738              
  Lines        27493    27529      +36     
  Branches      4610     4616       +6     
===========================================
+ Hits         19337    19386      +49     
+ Misses        6873     6862      -11     
+ Partials      1283     1281       -2     
Files with missing lines Coverage Δ
...android/sessionreplay/PrivacyOverrideExtensions.kt 100.00% <100.00%> (ø)
...nreplay/internal/recorder/SessionReplayRecorder.kt 97.01% <100.00%> (+0.02%) ⬆️
...essionreplay/internal/recorder/SnapshotProducer.kt 95.52% <100.00%> (+3.42%) ⬆️

... and 33 files with indirect coverage changes

@jonathanmos jonathanmos marked this pull request as ready for review October 8, 2024 10:09
@jonathanmos jonathanmos requested review from a team as code owners October 8, 2024 10:09
@jonathanmos jonathanmos force-pushed the jmoskovich/rum-6219/text-image-privacy-overrides branch from 83cf711 to 78d2981 Compare October 9, 2024 18:35
@jonathanmos jonathanmos force-pushed the jmoskovich/rum-6219/text-image-privacy-overrides branch 2 times, most recently from 6475493 to 8399c2a Compare October 14, 2024 07:07
@jonathanmos jonathanmos force-pushed the jmoskovich/rum-6218/implement-hidden-privacy-override branch from 715c7b1 to f16a5d4 Compare October 14, 2024 07:57
@jonathanmos jonathanmos force-pushed the jmoskovich/rum-6219/text-image-privacy-overrides branch from 8399c2a to 9124b62 Compare October 14, 2024 08:01
Base automatically changed from jmoskovich/rum-6218/implement-hidden-privacy-override to develop October 14, 2024 08:48
@jonathanmos jonathanmos merged commit ca952c5 into develop Oct 14, 2024
22 checks passed
@jonathanmos jonathanmos deleted the jmoskovich/rum-6219/text-image-privacy-overrides branch October 14, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants