🔥 (RUMM-997): Remove Resource duplication as Error

DataDog · Feb 25, 2021 · b18a181 · b18a181
1 parent 9b8e081
commit b18a181
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 331 deletions.
diff --git a/...android/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumResourceScope.kt b/...android/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumResourceScope.kt
@@ -176,18 +176,10 @@ internal class RumResourceScope(
             userExtraAttributes = user.extraInfo
         )
         writer.write(rumEvent)
-        if (isFailedHttpRequest(statusCode)) {
-            val errorMessage = ERROR_MSG_FORMAT.format(method, url)
-            sendError(errorMessage, RumErrorSource.NETWORK, statusCode, null, writer)
-        }
         parentScope.handleEvent(RumRawEvent.SentResource(), writer)
         sent = true
     }
 
-    private fun isFailedHttpRequest(statusCode: Long?): Boolean {
-        return (statusCode ?: 0) >= HTTP_ERROR_CODE_THRESHOLD
-    }
-
     private fun resolveResourceProvider(): ResourceEvent.Provider? {
         return if (firstPartyHostDetector.isFirstPartyUrl(url)) {
             ResourceEvent.Provider(

diff --git a/dd-sdk-android/src/test/kotlin/com/datadog/android/rum/assertj/ResourceEventAssert.kt b/dd-sdk-android/src/test/kotlin/com/datadog/android/rum/assertj/ResourceEventAssert.kt
@@ -76,6 +76,16 @@ internal class ResourceEventAssert(actual: ResourceEvent) :
         return this
     }
 
+    fun hasStatusCode(expected: Long?): ResourceEventAssert {
+        assertThat(actual.resource.statusCode)
+            .overridingErrorMessage(
+                "Expected event data to have resource.status_code $expected " +
+                    "but was ${actual.resource.statusCode}"
+            )
+            .isEqualTo(expected)
+        return this
+    }
+
     fun hasDurationGreaterThan(upperBound: Long): ResourceEventAssert {
         assertThat(actual.resource.duration)
             .overridingErrorMessage(