Skip to content

Commit

Permalink
Merge pull request #2276 from DataDog/yl/metrics/add-env-tag
Browse files Browse the repository at this point in the history
Add env tag in benchmark metrics
  • Loading branch information
ambushwork authored Sep 23, 2024
2 parents 5855613 + c546b72 commit 26c28e2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ internal class MetricRequestBodyBuilder(private val benchmarkContext: BenchmarkC
benchmarkContext.scenario?.let {
"$KEY_SCENARIO:$it"
},
"$KEY_TAG_APPLICATION_ID:${benchmarkContext.applicationId}"
"$KEY_TAG_APPLICATION_ID:${benchmarkContext.applicationId}",
"$KEY_ENV:${benchmarkContext.env}"
)
}

Expand Down Expand Up @@ -114,6 +115,7 @@ internal class MetricRequestBodyBuilder(private val benchmarkContext: BenchmarkC
private const val KEY_TAG_DEVICE_MODEL = "device_model"
private const val KEY_TAG_OS_VERSION = "os_version"
private const val KEY_TAG_RUN = "run"
private const val KEY_ENV = "env"
private const val KEY_TAG_APPLICATION_ID = "application_id"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ class MetricRequestBodyBuilderTest {
"os_version:${benchmarkContext.osVersion}",
"run:${benchmarkContext.run}",
"scenario:${benchmarkContext.scenario}",
"application_id:${benchmarkContext.applicationId}"
"application_id:${benchmarkContext.applicationId}",
"env:${benchmarkContext.env}"
)
)
hasMetricType(resolveMetricType(metricData[metricIndex].type).value)
Expand Down

0 comments on commit 26c28e2

Please sign in to comment.