-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not merge - additional resources support #189
base: main
Are you sure you want to change the base?
Commits on Aug 23, 2023
-
cleanup_org: failure on missing env var, use same env vars as cli: wi…
…thout DD_ prefix
Configuration menu - View commit details
-
Copy full SHA for 61e2c1c - Browse repository at this point
Copy the full SHA 61e2c1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a133155 - Browse repository at this point
Copy the full SHA a133155View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cbdf21 - Browse repository at this point
Copy the full SHA 4cbdf21View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd37f78 - Browse repository at this point
Copy the full SHA dd37f78View commit details
Commits on Sep 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a7e5867 - Browse repository at this point
Copy the full SHA a7e5867View commit details -
Configuration menu - View commit details
-
Copy full SHA for 455eb93 - Browse repository at this point
Copy the full SHA 455eb93View commit details -
needed for hack web frontend api usage (e.g. logs_facets) when defining config cookie_dogweb value, the client *switches* to cookie *only*: the api doesn't support both api/app key & cookie auth. => when setting cookie_dogweb config, it will break all standard resources types. also need csrf_token for destination as _authentication_token key in request payload for write actions.
Configuration menu - View commit details
-
Copy full SHA for 5e01b18 - Browse repository at this point
Copy the full SHA 5e01b18View commit details -
additional resource: logs_facets
- hardcoded source & target scopeid for now (seem to be internal index id, but which ones?) - use x-csrf-token as _authentication_token key in request payload for write actions
Configuration menu - View commit details
-
Copy full SHA for 0af262b - Browse repository at this point
Copy the full SHA 0af262bView commit details
Commits on Oct 6, 2023
-
additional resource: logs_views
- use dogweb cookie auth - use x-csrf-token as _authentication_token key in request payload for write actions
Configuration menu - View commit details
-
Copy full SHA for 8226ca5 - Browse repository at this point
Copy the full SHA 8226ca5View commit details -
additional resource: metric_metadatas
- get all metric metadata with standard v2 api, but it returns only ids - hack import_resource standard pattern to populate the dict that contains just 'id'; it's called during import just after get_resources() - get & update metric metadata uses v1 api, which doesn't have 'id' in its dict, hack adding it everywhere for consistency with v2/standard pattern - create metric metadata is *not* supported by datadog api, just update it on already existing metric: raise error explaining that: first push data-points on metric, then rerun the script - use standard pattern to get the destination resources (just ids here), and call update_resource() instead if it already exists - initial diff won't be the actual diff: it says it will create everything
Configuration menu - View commit details
-
Copy full SHA for 62293f4 - Browse repository at this point
Copy the full SHA 62293f4View commit details -
Fix crash on resource_connection when hitting None instead of object …
…just when len(keys_list) == 1
Configuration menu - View commit details
-
Copy full SHA for 9469688 - Browse repository at this point
Copy the full SHA 9469688View commit details -
additional resource: incidents
Only the base incident data is supported, related resources (integrations(slack), todos(remediations), attachments) may be done later with dedicated resources. The import is lossy: for example the creation date is on sync, timeline is lost, etc. - the datadog api documentation says only a subset of accepted fields for creation; in practice it does handles only a subset, and ignores the others => auto update just after create to sync more data - attributes.notification_handles ignored: too hard to reproduce properly, spams people during sync (or dates are all wrong); we don't really care about that piece of information => skip it - avoid forever diff on old incidents without `attributes.visibility`: hardcode `organization` value, it's what will be created on the destination organization anyway - incidents list api initially skipped old incidents without `visibility` field, exchange with datadog support resulted in a production fix - after full import: it seems users not yet active on the destination organization are in fact *not* notified (active incidents commanders are notified, and mandatory according to api documentation)
Configuration menu - View commit details
-
Copy full SHA for 276d2e0 - Browse repository at this point
Copy the full SHA 276d2e0View commit details -
Add deepomatic-specific incident fields migration: Namespace=>kube_na…
…mespace if kube_namespace is not null, don't overwrite: the data is better.
Configuration menu - View commit details
-
Copy full SHA for 9518f0d - Browse repository at this point
Copy the full SHA 9518f0dView commit details -
Fix crash in remove_excluded_attr() and remove_non_nullable_attribute…
…s() when last level is an array of non-nested objects
Configuration menu - View commit details
-
Copy full SHA for 395916d - Browse repository at this point
Copy the full SHA 395916dView commit details -
additional resource: incident_org_settings
- undocumented api, but standard v2 api used by web frontend, works with API/APP key - just one resource per org, forcing update, ignoring ids, etc.
Configuration menu - View commit details
-
Copy full SHA for 6e922d7 - Browse repository at this point
Copy the full SHA 6e922d7View commit details -
additional resource: incidents_config_fields
- unique by attributes.names - perpetual diff: on 'metadata' for ootb service & team: - PATCH ok (maybe ignores metadata?) - but PATCH response contains `metadata: null` => `diffs` always shows it; it's ok, we can ignore those
Configuration menu - View commit details
-
Copy full SHA for 6f8723c - Browse repository at this point
Copy the full SHA 6f8723cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f753f56 - Browse repository at this point
Copy the full SHA f753f56View commit details -
additional resource: incidents_config_integrations_workflows
Covers General>Integrations & Notifications>Rules - api inconsistency: `attributes.triggers.variables.severity_values` and `attributes.triggers.variables.status_values` are `null` in read calls, and require an array in write calls => skipping them with non_nullable_attr (fixed to support lists too) - errors (probably because some workflows are hardcoded, not duplicable, but no obvious attribute to distingish them) - Error: 400 Bad Request - {"errors":["a workflow like that already exists"]} - Error: 400 Bad Request - {"errors":["Invalid payload: 'name' is invalid"]} => ignoring those errors for now, and manually fixed `Send all incident updates to a global channel` via web frontend.
Configuration menu - View commit details
-
Copy full SHA for c46370a - Browse repository at this point
Copy the full SHA c46370aView commit details -
additional resource: incidents_todos
- iterate on all incidents, then for each incident, iterate on relationships 'todo'
Configuration menu - View commit details
-
Copy full SHA for 4daf218 - Browse repository at this point
Copy the full SHA 4daf218View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d8fd9c - Browse repository at this point
Copy the full SHA 8d8fd9cView commit details -
additional resource: integrations_slack_channels
- api doesn't support `display.muting` option, cf https://help.datadoghq.com/hc/en-us/requests/1380152
Configuration menu - View commit details
-
Copy full SHA for 2f48fa8 - Browse repository at this point
Copy the full SHA 2f48fa8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8adbb8 - Browse repository at this point
Copy the full SHA a8adbb8View commit details
Commits on Oct 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1d25d5d - Browse repository at this point
Copy the full SHA 1d25d5dView commit details