Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DCJ-742] Update codeowners for data team #989

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[DCJ-742] Update codeowners for data team #989

merged 1 commit into from
Oct 10, 2024

Conversation

fboulnois
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-742

Summary

Updates the CODEOWNERS with the new data team.

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner October 10, 2024 18:16
@fboulnois fboulnois requested review from rushtong and removed request for a team October 10, 2024 18:16
s-rubenstein
s-rubenstein approved these changes Oct 10, 2024
View reviewed changes
Copy link

@s-rubenstein s-rubenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the team being added

rushtong
rushtong approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@fboulnois fboulnois merged commit a0eb63a into develop Oct 10, 2024
12 checks passed
@fboulnois fboulnois deleted the fb-dcj-742-update-codeowners branch October 10, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-rubenstein s-rubenstein s-rubenstein approved these changes

@rushtong rushtong rushtong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fboulnois @rushtong @s-rubenstein