Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCJ-516: Use Workload Identity #975

Merged
merged 7 commits into from
Jul 24, 2024
Merged

DCJ-516: Use Workload Identity #975

merged 7 commits into from
Jul 24, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Jul 22, 2024 •
edited
Loading

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-516

Summary

Use Workload Identity to auth to GCR instead of GH secrets

See also:

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

This was referenced Jul 22, 2024
Merged
Merged
@rushtong rushtong marked this pull request as ready for review July 23, 2024 13:49
@rushtong rushtong requested a review from a team as a code owner July 23, 2024 13:49
@rushtong rushtong requested review from fboulnois and okotsopoulos and removed request for a team July 23, 2024 13:49
fboulnois
fboulnois requested changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See below:

.github/workflows/build.yaml Outdated Show resolved Hide resolved
aarohinadkarni
aarohinadkarni approved these changes Jul 24, 2024
View reviewed changes
Copy link

@aarohinadkarni aarohinadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

fboulnois
fboulnois approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rushtong rushtong merged commit 502c959 into develop Jul 24, 2024
12 checks passed
@rushtong rushtong deleted the gr-DCJ-516-gcr-auth branch July 24, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarohinadkarni aarohinadkarni aarohinadkarni approved these changes

@fboulnois fboulnois fboulnois approved these changes

@okotsopoulos okotsopoulos Awaiting requested review from okotsopoulos okotsopoulos was automatically assigned from DataBiosphere/data-custodian-journeys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rushtong @fboulnois @aarohinadkarni