Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCJ-400: Update to java 21 #969

Merged
merged 1 commit into from
Jun 25, 2024
Merged

DCJ-400: Update to java 21 #969

merged 1 commit into from
Jun 25, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Jun 24, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-400

Summary

Testing

Testing requires installing java 21 locally and ensuring that your local compose file is updated as well:

app:
  image: us.gcr.io/broad-dsp-gcr-public/base/jre:21-debian

The app should start up and run with no regressions.


Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong requested a review from a team as a code owner June 24, 2024 13:45
@rushtong rushtong requested review from fboulnois and aarohinadkarni and removed request for a team June 24, 2024 13:45
Copy link

@aarohinadkarni aarohinadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manually tested with local jvm update, looks good 👍

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@rushtong rushtong merged commit dc8c676 into develop Jun 25, 2024
12 checks passed
@rushtong rushtong deleted the gr-DCJ-400-java-21 branch June 25, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants