Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DCJ-15][risk=no] Make DCJ team codeowners #952

Merged
merged 1 commit into from
Apr 29, 2024
Merged

[DCJ-15][risk=no] Make DCJ team codeowners #952

merged 1 commit into from
Apr 29, 2024

Conversation

okotsopoulos
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-15

Summary

  • Make @DataBiosphere/data-custodian-journeys (new Github team) the default codeowners. I have also made the team an admin of this repository.
  • Remove explicit reviewer setting on Dependabot PRs: this will be handled by our Github team configuration.

Related PR with more context on team makeup, code review settings, and Slack scheduled reminders: DataBiosphere/jade-data-repo#1665

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@okotsopoulos
[DCJ-15] Make DCJ team codeowners
180c7bb 
And remove explicit reviewer setting on Dependabot PRs: this will be handled by our Github team configuration.
@okotsopoulos okotsopoulos changed the title [DCJ-15] Make DCJ team codeowners [DCJ-15][risk=no] Make DCJ team codeowners Apr 26, 2024
@okotsopoulos okotsopoulos marked this pull request as ready for review April 26, 2024 19:34
@okotsopoulos okotsopoulos requested a review from a team as a code owner April 26, 2024 19:34
@okotsopoulos okotsopoulos requested review from a team, rushtong and aarohinadkarni and removed request for a team April 26, 2024 19:34
rushtong
rushtong approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you 👍🏽

fboulnois
fboulnois approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@okotsopoulos okotsopoulos merged commit a40b21b into develop Apr 29, 2024
12 checks passed
@okotsopoulos okotsopoulos deleted the okotsopo-DCJ-15-dcj-codeowners branch April 29, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fboulnois fboulnois fboulnois approved these changes

@rushtong rushtong rushtong approved these changes

@aarohinadkarni aarohinadkarni Awaiting requested review from aarohinadkarni aarohinadkarni was automatically assigned from DataBiosphere/data-custodian-journeys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@okotsopoulos @rushtong @fboulnois