Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-2605]add approve rationale cases #877

Merged
merged 2 commits into from
Jul 19, 2023
Merged

[DUOS-2605]add approve rationale cases #877

merged 2 commits into from
Jul 19, 2023

Conversation

kaitlynoflaherty
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/jira/software/c/projects/DUOS/boards/123?modal=detail&selectedIssue=DUOS-2605

Summary

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@kaitlynoflaherty kaitlynoflaherty marked this pull request as ready for review July 18, 2023 19:36
@kaitlynoflaherty kaitlynoflaherty requested a review from a team as a code owner July 18, 2023 19:36
fboulnois
fboulnois approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

rushtong
rushtong approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@kaitlynoflaherty kaitlynoflaherty added this pull request to the merge queue Jul 19, 2023
Merged via the queue into develop with commit 4569054 Jul 19, 2023
@kaitlynoflaherty kaitlynoflaherty deleted the duos-2605 branch July 19, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fboulnois fboulnois fboulnois approved these changes

@rushtong rushtong rushtong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaitlynoflaherty @rushtong @fboulnois