Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update internal fluxes #333

Merged
merged 2 commits into from
Sep 27, 2024
Merged

update internal fluxes #333

merged 2 commits into from
Sep 27, 2024

Conversation

asjeb
Copy link
Collaborator

@asjeb asjeb commented Sep 27, 2024

No description provided.

@asjeb asjeb added the enhancement New feature or request label Sep 27, 2024
@asjeb asjeb self-assigned this Sep 27, 2024
@asjeb asjeb added this to the Release v1.1.0 milestone Sep 27, 2024
Copy link
Member

@nghi-truyen nghi-truyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci Apolline ! Tout bon pour moi ;)

@asjeb asjeb merged commit 4989cae into main Sep 27, 2024
22 checks passed
@inoelloc
Copy link
Member

@asjeb, @nghi-truyen, ca a été merge trop rapidement ..
Il y a un souci avec gr4-ri et gr5-ri. ps et es ont été rajoutés dans la liste des flux internes mais ils sont pas passés dans le tableau dans gr4_ri_time_step et gr5_ri_time_step décalant l'ensemble des flux internes à partir de perc.

@nghi-truyen
Copy link
Member

@asjeb, @nghi-truyen, ca a été merge trop rapidement .. Il y a un souci avec gr4-ri et gr5-ri. ps et es ont été rajoutés dans la liste des flux internes mais ils sont pas passés dans le tableau dans gr4_ri_time_step et gr5_ri_time_step décalant l'ensemble des flux internes à partir de perc.

Et oui, bien vu François ! Il faut rajouter ps et es dans les modèles ri de gr4 et gr5...

@asjeb
Copy link
Collaborator Author

asjeb commented Sep 27, 2024

ok je regarde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: add the infiltrating rainfall P_s and actual evapotranspiration flux E_s to return_options
3 participants