Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manage kernel pip #293

Merged
merged 7 commits into from
Aug 1, 2024
Merged

manage kernel pip #293

merged 7 commits into from
Aug 1, 2024

Conversation

asjeb
Copy link
Collaborator

@asjeb asjeb commented Jul 30, 2024

No description provided.

@asjeb asjeb added the documentation Improvements or additions to documentation label Jul 30, 2024
@asjeb asjeb added this to the Release v1.0.2 milestone Jul 30, 2024
Comment on lines 29 to 34
.. code-block:: none

conda create -n smash
conda activate smash
conda install pip
pip install hydro-smash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En testant, je vois que ca installe Python3.12 par défaut. Sur la version main, il y a les wheels pour Python3.12 mais pas sur maintenance ... On fait quoi ?

  • main: conda create -n smash python
  • maintenance: conda create -n smash python=3.11
    Si on precise python dans la commande create, il y a plus besoin du conda install pip

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cela signifie que si on a Python3.12, on ne peut pas installer la version de la maintenance1.0. ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ca download les sources sur PyPI et ca les compile en local donc ca peut marcher mais autant s'assurer d'utiliser directement les wheels

Comment on lines 26 to 27
If your system is **Ubuntu20** or if you use a servor machine, must install `smash` with an environment.
We recommend a environment using `Anaconda <https://www.anaconda.com/>`__.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ferais un truc plus général. Au schapi par exemple, ils sont sur debian et il y a le meme souci (je sais pas comment ca se passe sur Windows ou MacOS mais peut etre le meme pb). Une phrase comme If you have any compatibility issues with the system, we recommand using a virtual environment such as `Anaconda <https://www.anaconda.com/>`__.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@inoelloc inoelloc removed this from the Release v1.0.2 milestone Jul 30, 2024
Comment on lines 28 to 40
To install the last version of `smash` follow the commands:

.. code-block:: none

conda create -n smash python
pip install hydro-smash

To install a previous version use:

.. code-block:: none

conda create -n smash python=3.11
pip install hydro-smash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To install the last version of `smash` follow the commands:
.. code-block:: none
conda create -n smash python
pip install hydro-smash
To install a previous version use:
.. code-block:: none
conda create -n smash python=3.11
pip install hydro-smash
.. code-block:: none
conda create -n smash python
conda activate smash
pip install hydro-smash

Finalement, je prefère ta premiere version, désolé :3. Autant garder ca simple, et pas rentrer dans la gestion de version de Python et de smash en meme temps.

Pour le backport vers maintenance, on peut prendre la meme chose mais juste on précise la version de python

Copy link
Member

@inoelloc inoelloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juste avec l'indentation pour que ce soit dans la note et c'est tout bon !

doc/source/getting_started/index.rst Outdated Show resolved Hide resolved
@inoelloc inoelloc merged commit 45d0435 into main Aug 1, 2024
22 checks passed
@inoelloc inoelloc deleted the installation_note_main branch August 1, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants