-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manage kernel pip #293
manage kernel pip #293
Conversation
doc/source/getting_started/index.rst
Outdated
.. code-block:: none | ||
|
||
conda create -n smash | ||
conda activate smash | ||
conda install pip | ||
pip install hydro-smash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
En testant, je vois que ca installe Python3.12 par défaut. Sur la version main, il y a les wheels pour Python3.12 mais pas sur maintenance ... On fait quoi ?
- main:
conda create -n smash python
- maintenance:
conda create -n smash python=3.11
Si on precise python dans la commande create, il y a plus besoin du conda install pip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cela signifie que si on a Python3.12, on ne peut pas installer la version de la maintenance1.0. ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ca download les sources sur PyPI et ca les compile en local donc ca peut marcher mais autant s'assurer d'utiliser directement les wheels
doc/source/getting_started/index.rst
Outdated
If your system is **Ubuntu20** or if you use a servor machine, must install `smash` with an environment. | ||
We recommend a environment using `Anaconda <https://www.anaconda.com/>`__. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je ferais un truc plus général. Au schapi par exemple, ils sont sur debian et il y a le meme souci (je sais pas comment ca se passe sur Windows ou MacOS mais peut etre le meme pb). Une phrase comme If you have any compatibility issues with the system, we recommand using a virtual environment such as `Anaconda <https://www.anaconda.com/>`__.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
doc/source/getting_started/index.rst
Outdated
To install the last version of `smash` follow the commands: | ||
|
||
.. code-block:: none | ||
|
||
conda create -n smash python | ||
pip install hydro-smash | ||
|
||
To install a previous version use: | ||
|
||
.. code-block:: none | ||
|
||
conda create -n smash python=3.11 | ||
pip install hydro-smash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To install the last version of `smash` follow the commands: | |
.. code-block:: none | |
conda create -n smash python | |
pip install hydro-smash | |
To install a previous version use: | |
.. code-block:: none | |
conda create -n smash python=3.11 | |
pip install hydro-smash | |
.. code-block:: none | |
conda create -n smash python | |
conda activate smash | |
pip install hydro-smash |
Finalement, je prefère ta premiere version, désolé :3. Autant garder ca simple, et pas rentrer dans la gestion de version de Python et de smash en meme temps.
Pour le backport vers maintenance, on peut prendre la meme chose mais juste on précise la version de python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Juste avec l'indentation pour que ce soit dans la note et c'est tout bon !
Co-authored-by: Francois Colleoni <[email protected]>
No description provided.