Standardize boolean accept integer #217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintenance/1.0.x
…ly integer 0 and 1 but not Python boolean, thus Smash cannot read its own setup. This slight modification fix this pb. it is now possible to extract setup from a model without write it in hdf5 and create a new model from this identical setup (just warning are displayed because unrecognize options).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salut,
Le fichier setup yml contient des boolens
Le dictionnaire python setup contient des boolens
setup est utilisé pour la création de l'objet model en entrée de smash.Model()
En résultat la variable model.setup contient des entiers à la place des boolens
=> le dictionnaire setup peut donc maintenant contenir des entiers 1 ou 0 à la place des boolens (plus facile lorsque l'on copie les valeurs de model.setup vers un nouveau setup)