-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFC: Fix Mifare DESFire reading #757
base: dev
Are you sure you want to change the base?
Conversation
cc @Leptopt1los for
|
hi @Willy-JL! sorry for delay. i tested this PR and unfortunately it beaks emv read. i tried to come to a different solution again, but today my buggy emv card died. i will order new one. will ping you here when i get it, ok? |
Sounds good to me! I think it's worth noting that some emv card do still read with this PR, it seems to be an exception rather than the rule with the one you had. It might be worth considering merging as a temporary fix since the trade-off is no desfire at all, or only some emv cards break, but that decision is for your team to make. I'll gladly try to find the root cause when you receive the new card :D |
Since we are currently in situation when we have options
I chosen 3rd option and did this Ill keep PR open until we found solution to fully fix that, which is impossible without test card at the moment sadly |
What's new
Verification
Checklist (For Reviewer)