Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java version to 21 #90

Merged
merged 9 commits into from
May 6, 2024
Merged

Update java version to 21 #90

merged 9 commits into from
May 6, 2024

Conversation

Dankoy
Copy link
Owner

@Dankoy Dankoy commented May 6, 2024

Description

Updated java from 17 to 21.

Since in java 21 freemarker started to print new lines, I fixed it with <#t> tag.

Also added try-with-resources for executors.

Added spotless linter

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Export new words from sqlite db. Shoud work correctly

Test Configuration:

  • Firmware version: Windows 11
  • Hardware:
  • SDK: Oracle JDK 21.0.3+7-LTS-152

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Dankoy Dankoy added the dependencies Pull requests that update a dependency file label May 6, 2024
@Dankoy Dankoy self-assigned this May 6, 2024
@Dankoy Dankoy merged commit 8952f74 into main May 6, 2024
10 checks passed
@Dankoy Dankoy deleted the update-java branch May 6, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant