fix: birthday being undefined (#23)

* fix: birthday being undefined * fix: add test
DanielRamosAcosta · Apr 1, 2024 · 9d106de · 9d106de
1 parent b5dd292
commit 9d106de
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/infrastructure/factorial-client/schema/Employee.ts b/src/infrastructure/factorial-client/schema/Employee.ts
@@ -23,7 +23,7 @@ export const Employee = z.object({
   preferredName: z.string().nullable(),
   pronouns: z.string().nullable(),
   regularAccessStartsOn: z.string().nullable(),
-  showBirthday: z.boolean(),
+  showBirthday: z.boolean().optional(),
   supervisedByCurrent: z.boolean(),
   tenureStartDate: z.string().nullable(),
   terminatedOn: z.string().nullable(),

diff --git a/test/fixtures/employees.json b/test/fixtures/employees.json
@@ -267,7 +267,6 @@
     "regularAccessStartsOn": "2019-10-04",
     "irpf": null,
     "pronouns": null,
-    "showBirthday": true,
     "permissions": {
       "hirings": {
         "read": true,