Fix integer overflow when computing bounding box in NvDsInferParseYoloV4 and NvDsInferParseYoloV5 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oV4 and NvDsInferParseYoloV5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top and left values of a bounding box can sometimes be negative in degenerate cases. For instance, if an object is very close to the border of the image, top value could be -1. This would cause integer overflow due to assignment of negative values to unsigned int.
The fix prevents the integer overflow in functions NvDsInferParseYoloV4 and NvDsInferParseYoloV5 by guaranteeing that top and left values are always nonnegative.