Merge pull request #5 from KeizerDev/fix-path

Used REALPATH to prevent dots in path as a result of strange behaviour with chrome headless
DaanDeSmedt · Mar 12, 2018 · 76c3ba6 · 76c3ba6
2 parents 0750b42 + 4bce3f1
commit 76c3ba6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -55,3 +55,6 @@ $RECYCLE.BIN/
 
 # Windows shortcuts
 *.lnk
+
+
+.idea/
diff --git a/src/HeadlessChrome.php b/src/HeadlessChrome.php
@@ -130,10 +130,10 @@ public function setUrl($url) {
      */
     public function setOutputDirectory($directory)
     {
-        $this->outputDirectory = trim($directory);
-        if (!file_exists($directory)) {
+        if (!file_exists($directory) || !realpath($directory)) {
             @mkdir($directory);
         }
+        $this->outputDirectory = realpath(trim($directory));
     }
 
 

diff --git a/tests/HeadlessChromeTestSuite.php b/tests/HeadlessChromeTestSuite.php
@@ -34,7 +34,7 @@ public function testSetURL() {
     public function testSetOutputDirectory() {
         $headlessChromer = new HeadlessChrome();
         $headlessChromer->setOutputDirectory($this->ouputDirectory);
-        $this->assertEquals($this->ouputDirectory, $headlessChromer->getOutputDirectory());
+        $this->assertEquals(realpath($this->ouputDirectory), $headlessChromer->getOutputDirectory());
     }