Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#156] 공지사항/펀시스템 상세정보 page id 리팩토링 #157

Merged
merged 2 commits into from
Dec 28, 2023
Merged

[#156] 공지사항/펀시스템 상세정보 page id 리팩토링 #157

merged 2 commits into from
Dec 28, 2023

Conversation

SujinKim1127
Copy link
Member

@SujinKim1127 SujinKim1127 commented Dec 22, 2023 •
edited
Loading

Issue

Description

기존에 적었던 코드 두 줄을

const numericPart = path.match(/\d+/);
const pathId = numericPart ? numericPart[0] : 1;

정우님이 알려주신 방식대로 아래처럼 바꿔서 작성했습니다

const pathId = router.query.id;

Check List

  • PR 제목을 커밋 규칙에 맞게 작성
  • PR에 해당되는 Issue를 연결 완료
  • 적절한 라벨 설정
  • 작업한 사람 모두를 Assign
  • 작업한 팀에게 Code Review 요청 (Reviewer 등록)
  • main 브랜치의 최신 상태를 반영하고 있는지 확인

Screenshot

@SujinKim1127 SujinKim1127 added the refactor 🧰 기존 코드를 리팩토링 하는 Issue label Dec 22, 2023
@SujinKim1127 SujinKim1127 self-assigned this Dec 22, 2023
@vercel Vercel
Copy link

vercel bot commented Dec 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daitssu-client ✅ Ready (Inspect) Visit Preview Dec 22, 2023 4:21am

@SujinKim1127 SujinKim1127 linked an issue Dec 22, 2023 that may be closed by this pull request
[refactor] 공지사항/펀시스템 상세조회 코드 리팩토링 #156
Closed
halfmoon-mind
halfmoon-mind approved these changes Dec 23, 2023
View reviewed changes
Copy link
Member

@halfmoon-mind halfmoon-mind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿,,,!

@halfmoon-mind halfmoon-mind merged commit d945950 into main Dec 28, 2023
3 checks passed
@halfmoon-mind halfmoon-mind deleted the refactor/#156 branch December 28, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halfmoon-mind halfmoon-mind halfmoon-mind approved these changes

@chan0310 chan0310 Awaiting requested review from chan0310

@JooHui-void JooHui-void Awaiting requested review from JooHui-void

@jwo0o0 jwo0o0 Awaiting requested review from jwo0o0

Assignees

@SujinKim1127 SujinKim1127

Labels
refactor 🧰 기존 코드를 리팩토링 하는 Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[refactor] 공지사항/펀시스템 상세조회 코드 리팩토링
2 participants
@SujinKim1127 @halfmoon-mind