Swapped -999...s for #defined constants, including NaNs #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a little worried about NaNs. Sometimes they aren't handeled well, and you may not notice the misbehavior if you're not looking for it. Like if you have a cut for a != b, then it always evaluates to true if a or b is NaN. Personally, sticking to -999999999 makes sense and is less likely to cause issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on some Slack chatter I swapped out most of the -999...s for
__TMS_BAD_NUMBER__ = -99999999if it's an int, and with a NaN defined as__TMS_NAN__for any doubles.I haven't properly tested this, hence the draft. Need to check that the timeslicing or other output isn't affected (other than some out-of-range values changing around).