Unit Tests for trigger object behavior in buffers/requests #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d, request handling, etc.
|
DUNE-DAQ/datahandlinglibs#27 has now been merged to develop, so when this is reviewed it can be merged too. |
ArturSztuc
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements unit tests using the common datahandlinglibs test functions that check the SkipListLatencyBuffer with enclosed trigger types (TriggerPrimitiveTypeAdapter, TAWrapper, TCWrapper), with respect to returning the correct lower_bound behavior and to responding to requests to form fragments properly.
Note that the TAWrapper and TCWrappers need a bit more care in making sure the underling data is populated on the construction of the test objects. There should (hopefully...) be no change in the behavior of the code that isn't intended.
This PR needs DUNE-DAQ/datahandlinglibs#27. With that pulled down, to run the unit tests, do
dbt-build --unittest trigger
We should wait to merge this PR in until the datahandlinglibs PR has been approved and merged as well.