Merge pull request #52 from DUNE-DAQ/aeo/remove-build-warnings

Remove Build Warnings
DUNE-DAQ · Oct 28, 2024 · eb63085 · eb63085
2 parents b2816b8 + da60d3d
commit eb63085
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 26 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -31,7 +31,7 @@ find_package(Boost COMPONENTS unit_test_framework REQUIRED)
 
 # See https://dune-daq-sw.readthedocs.io/en/latest/packages/daq-cmake/#daq_add_library
 
-daq_add_library( LINK_LIBRARIES hdf5libs::hdf5libs trgdataformats::trgdataformats triggeralgs::triggeralgs detchannelmaps::detchannelmaps) # Any source files and/or dependent libraries to link in not yet determined
+daq_add_library(*.cpp LINK_LIBRARIES hdf5libs::hdf5libs trgdataformats::trgdataformats triggeralgs::triggeralgs detchannelmaps::detchannelmaps CLI11::CLI11 fmt::fmt nlohmann_json::nlohmann_json)
 
 ##############################################################################
 
@@ -47,9 +47,9 @@ daq_add_python_bindings(*.cpp LINK_LIBRARIES ${PROJECT_NAME} ) # Any additional
 
 # See https://dune-daq-sw.readthedocs.io/en/latest/packages/daq-cmake/#daq_add_application
 
-daq_add_application(trgtools_tapipe tapipe.cxx LINK_LIBRARIES ${PROJECT_NAME} CLI11::CLI11 fmt::fmt) # Any libraries to link in not yet determined
-daq_add_application(trgtools_copy_tpstream copy_tpstream.cxx LINK_LIBRARIES ${PROJECT_NAME} CLI11::CLI11 fmt::fmt) # Any libraries to link in not yet determined
-daq_add_application(trgtools_process_tpstream process_tpstream.cxx LINK_LIBRARIES ${PROJECT_NAME} CLI11::CLI11 fmt::fmt triggeralgs::triggeralgs trgdataformats::trgdataformats hdf5libs::hdf5libs detchannelmaps::detchannelmaps)
+daq_add_application(trgtools_tapipe tapipe.cxx LINK_LIBRARIES ${PROJECT_NAME})
+daq_add_application(trgtools_copy_tpstream copy_tpstream.cxx LINK_LIBRARIES ${PROJECT_NAME})
+daq_add_application(trgtools_process_tpstream process_tpstream.cxx LINK_LIBRARIES ${PROJECT_NAME})
 
 ##############################################################################
 

diff --git a/pybindsrc/module.cpp b/pybindsrc/module.cpp
@@ -23,7 +23,7 @@ PYBIND11_MODULE(_daq_trgtools_py, m)
   // You'd want to change renameme to the name of a function which
   // you'd like to have a python binding to
 
-  register_renameme(m);
+  // register_renameme(m);
 }
 
 } // namespace dunedaq::trgtools::python
diff --git a/pybindsrc/pythonbindingsrenameme.cpp b/pybindsrc/pythonbindingsrenameme.cpp
diff --git a/pybindsrc/registrators.hpp b/pybindsrc/registrators.hpp
@@ -16,7 +16,7 @@
 
 namespace dunedaq::trgtools::python {
 
-  void register_renameme(pybind11::module&);
+//  void register_renameme(pybind11::module&);
 
 }