Remove HTTP and TFTP write timeouts

These timeouts were disrupting downloads to slower clients for larger proxied content.
DSpeichert · Sep 6, 2021 · f6d1736 · f6d1736
1 parent 2636b54
commit f6d1736
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/httpd/server.go b/httpd/server.go
@@ -22,7 +22,6 @@ func NewServer(store *store.Store) (server *Server, err error) {
 	server = &Server{
 		httpServer: &http.Server{
 			ReadTimeout:    10 * time.Second,
-			WriteTimeout:   10 * time.Second,
 			MaxHeaderBytes: 1 << 20,
 			IdleTimeout:    10 * time.Second,
 		},

diff --git a/tftpd/server.go b/tftpd/server.go
@@ -7,7 +7,6 @@ import (
 	"github.com/rs/zerolog/log"
 	"net"
 	"net/http"
-	"time"
 )
 
 type Server struct {
@@ -21,11 +20,9 @@ type Server struct {
 func NewServer(store *store.Store) (server *Server, err error) {
 
 	server = &Server{
-		httpClient: &http.Client{
-			Timeout: time.Second * 30,
-		},
-		logger: log.With().Str("service", "tftp").Logger(),
-		store:  store,
+		httpClient: &http.Client{},
+		logger:     log.With().Str("service", "tftp").Logger(),
+		store:      store,
 	}
 
 	return server, nil