[dspace-7_x] Fix Collection Page e2e test. Wait on page to fully load #3460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
added
1 APPROVAL
…ests. This ensures Collection page is fully loaded because viewevent triggers upon loading.
tdonohue
force-pushed
the
fix_collection_e2e_test
branch
from
2e0f4ad
to
8c88f70
Compare
|
Success! This seems to fix the annoying issues we are having on |
tdonohue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Frequently, the
collection-page.cy.tsis failing because the e2e test times out before the Collection Page fully loads. This simply updates the test to wait on the "viewevents" to return before performing any other tests. The reason this works is that the "viewevents" request occurs within the<ds-collection-page>tag.Instructions for Reviewers