-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Port dspace-7_x] Implement e2e accessibility tests for pages in DSpace User Interface #3405
Merged
tdonohue
merged 17 commits into
DSpace:dspace-7_x
from
4Science:task/backport-3213-to-dspace-7_x
Oct 10, 2024
Merged
[Port dspace-7_x] Implement e2e accessibility tests for pages in DSpace User Interface #3405
tdonohue
merged 17 commits into
DSpace:dspace-7_x
from
4Science:task/backport-3213-to-dspace-7_x
Oct 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metadata Import Batch Import Processes Overview New Process Quality Assurance Sources
Edit Eperson Edit Group Create EPerson Epeople Registry Groups Registry
Admin Notifications Publication Claim Admin Search Page Bulk Access Create Group Metadata Registry
Admin Curation Task Bitstream Format Health Page Metadata Schema
Admin Add New Modals Admin Edit Modals Admin Export Modals Admin Workflow Page End User Agreement Feedback Profile Page System Wide Alert
…sibility issue in pagination component
tdonohue
changed the title
Task/backport 3213 to dspace 7 x
[Port dspace-7_x] All pages in the DSpace User Interface should have automated accessibility tests
Oct 10, 2024
tdonohue
added
bug
accessibility
high priority
claimed: 4Science
4Science team is working on this issue & will contribute back
funded
Task is funded via the DSpace Development Fund
labels
Oct 10, 2024
tdonohue
changed the title
[Port dspace-7_x] All pages in the DSpace User Interface should have automated accessibility tests
[Port dspace-7_x] Implement e2e accessibility tests for pages in DSpace User Interface
Oct 10, 2024
tdonohue
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @FrancescoMolinaro for backporting this to 7.x. I gave this a code review, and the PR is now passing all e2e tests. So, this looks ready to merge!
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accessibility
bug
claimed: 4Science
4Science team is working on this issue & will contribute back
funded
Task is funded via the DSpace Development Fund
high priority
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Add references/links to any related issues or PRs. These may include:
Backporting of #3213 to
dspace-7_x
Description
Backporting from version 8.x to 7.x
List of changes in this PR:
Added e2e tests for accessibility.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
main
branch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lint
npm run check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.