Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port dspace-7_x] Implement e2e accessibility tests for pages in DSpace User Interface #3405

Merged
merged 17 commits into from
Oct 10, 2024

Conversation

FrancescoMolinaro
Copy link
Contributor

@FrancescoMolinaro FrancescoMolinaro commented Oct 10, 2024

References

Add references/links to any related issues or PRs. These may include:

Backporting of #3213 to dspace-7_x

Description

Backporting from version 8.x to 7.x

List of changes in this PR:

Added e2e tests for accessibility.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Metadata Import
Batch Import
Processes Overview
New Process
Quality Assurance Sources
Edit Eperson
Edit Group
Create EPerson
Epeople Registry
Groups Registry
Admin Notifications Publication Claim
Admin Search Page
Bulk Access
Create Group
Metadata Registry
Admin Curation Task
Bitstream Format
Health Page
Metadata Schema
Admin Add New Modals
Admin Edit Modals
Admin Export Modals
Admin Workflow Page
End User Agreement
Feedback
Profile Page
System Wide Alert
@tdonohue tdonohue changed the title Task/backport 3213 to dspace 7 x [Port dspace-7_x] All pages in the DSpace User Interface should have automated accessibility tests Oct 10, 2024
@tdonohue tdonohue added bug accessibility high priority claimed: 4Science 4Science team is working on this issue & will contribute back funded Task is funded via the DSpace Development Fund labels Oct 10, 2024
@tdonohue tdonohue added this to the 7.6.3 milestone Oct 10, 2024
@tdonohue tdonohue changed the title [Port dspace-7_x] All pages in the DSpace User Interface should have automated accessibility tests [Port dspace-7_x] Implement e2e accessibility tests for pages in DSpace User Interface Oct 10, 2024
@tdonohue tdonohue self-requested a review October 10, 2024 18:15
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @FrancescoMolinaro for backporting this to 7.x. I gave this a code review, and the PR is now passing all e2e tests. So, this looks ready to merge!

@tdonohue tdonohue merged commit e74dc22 into DSpace:dspace-7_x Oct 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug claimed: 4Science 4Science team is working on this issue & will contribute back funded Task is funded via the DSpace Development Fund high priority
Projects
Development

Successfully merging this pull request may close these issues.

2 participants