Ignore some paths from file watcher #3289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watching all these directories can cause systems to exceed maximum watched files / inotify limits, especially in dev mode with IDEs etc also watching files.
I've included node_modules, and some basic vcs and project dirs that should be excluded.
Testing
It's actually not super trivial to 'see' watched files, but if you can reproduce the underlying issue (get your system into a state where inotify limit is exceeded), then you can run with and without this change, and review any errors listed, to see whether the file watcher is attempting to watch e.g. node_modules
(if anyone has any better test procedures please let me know!)
Notes
Documentation: https://webpack.js.org/configuration/watch/#watchoptions
Note, there is also a way to do this in tsconfig.json but in my practical testing it wasn't taking effect (see: https://www.typescriptlang.org/tsconfig/#watchOptions)
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
main
branch of code (unless it is a backport or is fixing an issue specific to an older branch).yarn lint