-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for submission describe warning contribution bug #2905
Fix for submission describe warning contribution bug #2905
Conversation
@tdonohue The codecov check keeps failing, do you have any idea what's wrong? |
@LotteHofstede : I've pushed up a possible fix to Codecov in #2910 . So, if you rebase this PR on the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @LotteHofstede
i've tested it and the issue is resolved, LGTM
Successfully created backport PR for |
References
Description
This PR fixes an issue where on save the first describe step wouldn't show it was validated after saving with certain configurations.
Instructions for Reviewers
Add the follow configuration as the first describe step to the input forms configuration:
Start a new submission that uses this configuration and click fill out the first describe step correctly (set a type).
Click "Save" and check that the orange (!) icon at the top has changed into a green checkmark.
Checklist
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.