Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for submission describe warning contribution bug #2905

Conversation

LotteHofstede
Copy link
Contributor

References

Description

This PR fixes an issue where on save the first describe step wouldn't show it was validated after saving with certain configurations.

Instructions for Reviewers

Add the follow configuration as the first describe step to the input forms configuration:

   <form name="traditionalpageone">
        <row>
            <field>
                <dc-schema>dc</dc-schema>
                <dc-element>type</dc-element>
                <repeatable>false</repeatable>
                <label>Type</label>
                <input-type value-pairs-name="common_types">dropdown</input-type>
                <hint>Select the type of content of the item.</hint>
                <required>You must enter a type for this item</required>
            </field>
        </row>
    </form>

Start a new submission that uses this configuration and click fill out the first describe step correctly (set a type).
Click "Save" and check that the orange (!) icon at the top has changed into a green checkmark.

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@LotteHofstede LotteHofstede self-assigned this Apr 8, 2024
@LotteHofstede
Copy link
Contributor Author

@tdonohue The codecov check keeps failing, do you have any idea what's wrong?

@tdonohue tdonohue added bug component: submission 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Apr 8, 2024
@tdonohue
Copy link
Member

tdonohue commented Apr 8, 2024

@LotteHofstede : I've pushed up a possible fix to Codecov in #2910 . So, if you rebase this PR on the latest main, that may fix the issues. (Codecov has been flakey lately, so I'm hoping that upgrade to the Codecov action will fix the issues)

@tdonohue tdonohue requested a review from atarix83 April 11, 2024 14:48
Copy link
Contributor

@atarix83 atarix83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @LotteHofstede

i've tested it and the issue is resolved, LGTM

@tdonohue tdonohue added this to the 8.0 milestone Apr 11, 2024
@tdonohue tdonohue merged commit d29d3ca into DSpace:main Apr 12, 2024
10 of 11 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-7_x:

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: submission
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Submission warning icon does not change to checkmark when valid for certain configurations
4 participants