ROR Integration - Identifier Visualization

[vins01-4science]

Please note that this development has been funded by the University of California - California Digital Library.

References

• Requires ROR Integration - Live Import DSpace#9238

Description

This PR introduces i18n-labels and visualization of the ROR identifier inside the organization page, as suggested by the ROR-ID guidelines

Instructions for Reviewers

Just import a new Organization using the ROR live-import feature and check that all the labels are correctly shown, and also that inside the organization page the ROR identifier is correctly shown.

List of changes in this PR:

• Introduces new en labels
• Introduces ROR identifier visualization for the Orgunit component
• Adds new ROR image to the assets folder

Checklist

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using yarn lint
• My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[paulo-graca]

Thank you, @vins01-4science, for this contribution! I think it will be very useful. The only thing I would like your feedback on is whether you considered creating a new specific component that extends ItemPageFieldComponent instead of changing the default generic component, enabling it to support images.

[tdonohue]

@vins01-4science : Overall this works. I tested it with the backend PR and didn't find any obvious major bugs. That said, I did find some missing i18n keys and some other small issues in the code itself. See inline comments below.

[github-actions]

Hi @vins01-4science,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[vins01-4science]

Thank you, @vins01-4science, for this contribution! I think it will be very useful. The only thing I would like your feedback on is whether you considered creating a new specific component that extends ItemPageFieldComponent instead of changing the default generic component, enabling it to support images.

@vins01-4science : Overall this works. I tested it with the backend PR and didn't find any obvious major bugs. That said, I did find some missing i18n keys and some other small issues in the code itself. See inline comments below.

Thank you @paulo-graca and @tdonohue for the review,

all the changes have been addressed now.

Let me know if you find something else!

[tdonohue]

👍 Thanks @vins01-4science ! I've re-reviewed and retested today with the backend PR. Everything is working well now, and I've verified also that both my and @paulo-graca 's feedback has been addressed.

[tdonohue]

I've flagged this as needs documentation just because we need to add ROR to the list of external sources for 8.0 here: https://wiki.lyrasis.org/pages/viewpage.action?pageId=315720684#ImportingItemsviabasicbibliographicformats(Endnote,BibTex,RIS,CSV,etc)andonlineservices(arXiv,PubMed,CrossRef,CiNii,etc)-SupportedExternalSources

Once it is added, we can remove this label

[vins01-4science]

I've flagged this as needs documentation just because we need to add ROR to the list of external sources for 8.0 here: https://wiki.lyrasis.org/pages/viewpage.action?pageId=315720684#ImportingItemsviabasicbibliographicformats(Endnote,BibTex,RIS,CSV,etc)andonlineservices(arXiv,PubMed,CrossRef,CiNii,etc)-SupportedExternalSources

Once it is added, we can remove this label

Thank you @tdonohue,

I have updated the documentation just like you told me.
You can find all my changes here: ROR-Integration.

Let me know if you need something else.

[tdonohue]

Thanks @vins01-4science ! I'll remove the `needs documentation label.