Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action to automatically create a port PR (based on label) & minor bug fixes #2406

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

tdonohue
Copy link
Member

References

Description

Main feature is to add a custom PR port action to automatically port PRs to other branches (depending on the label).

How it works

Suppose a PR is created against main and labeled with port to dspace-7_x (this label needs to be created).

  1. When that PR is merged, this new action will trigger.
  2. Because the merged PR has the port to dspace-7_x label, this action will attempt to create a new PR against the dspace-7_x branch with the same commits (cherry-picked) as the main PR.
  3. Assuming the new PR can be created, it will be linked back to the original PR via a comment. At this point, we can wait for the PR to pass tests & then merge immediately.
  4. If the new PR fails to be created, then a comment will be added to the original PR which says it failed. At this point, we'd have to do a manual port.
    (NOTE: This same process will also work if the original PR was created against dspace-7_x and the PR is labeled with port to main)

Here's an example that I tried with a test repo:

SEE ALSO description in DSpace/DSpace#8988

@tdonohue tdonohue added code task port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Jul 28, 2023
@tdonohue tdonohue added this to the 8.0 milestone Jul 28, 2023
@tdonohue
Copy link
Member Author

Merging immediately to sync DSpace/dspace-angular with DSpace/DSpace

@tdonohue tdonohue merged commit 1223e3c into DSpace:main Jul 28, 2023
10 checks passed
@tdonohue tdonohue deleted the update_actions branch July 28, 2023 20:11
@dspace-bot
Copy link
Contributor

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants